Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: switch from ethjs-query to @ethersproject/providers #39

Merged
merged 2 commits into from
Sep 25, 2023
Merged

deps: switch from ethjs-query to @ethersproject/providers #39

merged 2 commits into from
Sep 25, 2023

Conversation

legobeat
Copy link
Contributor

ethjs-query is orphaned. Replacing this with more recently maintained @ethersproject/providers removes implicit peerDependency on babel-runtime and more up-to-date bignumber implementation.

@legobeat legobeat marked this pull request as ready for review July 14, 2023 05:19
@legobeat legobeat requested a review from a team as a code owner July 14, 2023 05:19
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@socket-security
Copy link

socket-security bot commented Jul 14, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@ethersproject/providers 5.7.2 network +24 3 MB ricmoo

🚮 Removed packages: ethjs-query@0.3.8

@socket-security
Copy link

socket-security bot commented Jul 14, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: bech32@1.1.4, @ethersproject/web@5.7.1, ws@7.4.6

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore bech32@1.1.4
@SocketSecurity ignore js-sha3@0.8.0
@SocketSecurity ignore ws@7.4.6
@SocketSecurity ignore @ethersproject/web@5.7.1
@SocketSecurity ignore @ethersproject/providers@5.7.2

@legobeat legobeat requested a review from a team July 17, 2023 16:56
mcmire
mcmire approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking question.

package.json
@@ -24,8 +24,8 @@
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write"
},
"dependencies": {
"async-mutex": "^0.3.1",
"ethjs-query": "^0.3.8"
"@ethersproject/providers": "^5.7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming version 6.x isn't going to work with the types that already exist in this project right?

Copy link
Contributor Author

@legobeat legobeat Jul 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pondering if it's meaningful and worth it going straight to 6, skipping 5.Noting that 5 is what's in use in metamask-extension today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering v5 is also used in https://github.com/MetaMask/smart-transactions-controller as of now, it seems like the conservative choice for now - so yes, I think it makes sense that this would not consider ethers v6 compatibility. Sounds OK?

@legobeat legobeat requested a review from a team July 17, 2023 18:19
@legobeat legobeat mentioned this pull request Sep 6, 2023
Closed
@legobeat legobeat merged commit 1537632 into MetaMask:main Sep 25, 2023
@legobeat legobeat mentioned this pull request Nov 15, 2023
Merged
3 tasks
@mcmire mcmire mentioned this pull request Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire